----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33867/#review82698 -----------------------------------------------------------
common/src/test/java/org/apache/falcon/entity/parser/ClusterEntityParserTest.java <https://reviews.apache.org/r/33867/#comment133485> Can this method be modified to return unique locations instead of caller passing it? This would avoid conflict when new tests are written and the same locations are reused. Also please add the cleanup method which cleans up all the locations created. - Sowmya Ramesh On May 5, 2015, 10:37 p.m., Balu Vellanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33867/ > ----------------------------------------------------------- > > (Updated May 5, 2015, 10:37 p.m.) > > > Review request for Falcon, Sowmya Ramesh and Venkat Ranganathan. > > > Bugs: Falcon-1195 > https://issues.apache.org/jira/browse/Falcon-1195 > > > Repository: falcon-git > > > Description > ------- > > testClusterWithOnlyStaging fails intermittently due to race condition in > creating working dir for cluster. This can be fixed by creating a different > working/staging dir for each test case. > > > Diffs > ----- > > > common/src/test/java/org/apache/falcon/entity/parser/ClusterEntityParserTest.java > 4920d03 > > Diff: https://reviews.apache.org/r/33867/diff/ > > > Testing > ------- > > Ran unit tests multiple times to verify the changes. > > > Thanks, > > Balu Vellanki > >
