> On May 7, 2015, 10:51 a.m., Ajay Yadava wrote: > >
Thanks Ajay for your comments. > On May 7, 2015, 10:51 a.m., Ajay Yadava wrote: > > oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java, > > line 198 > > <https://reviews.apache.org/r/33892/diff/1/?file=951149#file951149line198> > > > > We also need to log (warning) here that no new libraries were copied. > > If any new libraries were added then they will have to be copied manually. Log message added. > On May 7, 2015, 10:51 a.m., Ajay Yadava wrote: > > oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java, > > line 199 > > <https://reviews.apache.org/r/33892/diff/1/?file=951149#file951149line199> > > > > How about just catching the exception here and remove all other > > changes? This way during reload we can silence the error in copying libs to > > HDFS without changing the code anywhere else. In this issue, Falon fail to restart when FS exception occurred at the time of reloading cluster entities. So I am of the opinion that we should capture this FS exception only, at the time of FS initialization in addLibsTo method. - Peeyush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33892/#review82815 ----------------------------------------------------------- On May 6, 2015, 12:47 p.m., Peeyush Bishnoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33892/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 12:47 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1165 > https://issues.apache.org/jira/browse/FALCON-1165 > > > Repository: falcon-git > > > Description > ------- > > FALCON-1165 : Falcon restart failed, if defined service in cluster entity is > unreachable > > > Diffs > ----- > > > oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java > b3b7bf3 > > Diff: https://reviews.apache.org/r/33892/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Peeyush Bishnoi > >
