-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33965/#review83116
-----------------------------------------------------------



falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java
<https://reviews.apache.org/r/33965/#comment133987>

    Inconsistent indentation. Pleave run:
    mvn -Phadoop2 clean verify
    
    For intellij you can use this profile, which will do a good part of the 
work for you:
    
https://docs.google.com/a/hortonworks.com/file/d/0BzSi0sEwnHOaVWZERllsSEpReUk/edit


Looks good to me. Since, I was guiding Namit with the process, it would be 
better if someone else also reviews it.

- Raghav Gautam


On May 7, 2015, 5:58 p.m., Namit Maheshwari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33965/
> -----------------------------------------------------------
> 
> (Updated May 7, 2015, 5:58 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1201
>     https://issues.apache.org/jira/browse/FALCON-1201
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Test 1. testHeader 
> Test 2. testWizardDefaultScenario - Run full feed creation scenario.
> 
> 
> Diffs
> -----
> 
>   
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java
>  eaaeba25307bf2f494d76cd5de080aadcbd6ce54 
>   
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java
>  PRE-CREATION 
>   
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/NewFeedPage.java
>  4863da3e146d23eef0f749766e5040d0a1cbc154 
>   
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java
>  b9d766f722377cf36eb08a938f8f38b143021f28 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33965/diff/
> 
> 
> Testing
> -------
> 
> Tested, that the pages are filled fine and test pass.
> 
> 
> Thanks,
> 
> Namit Maheshwari
> 
>

Reply via email to