I was not sure if node_modules was part of this release only or was part of earlier releases also. Just got confirmation that they are introduced in this release.
Changing my vote to -1 for licensing issues. Thanks Amareshwari On Tue, May 12, 2015 at 12:46 PM, amareshwarisr . <amareshw...@gmail.com> wrote: > 0 (i'm facing build issues for building from source). > > - Signature looks good > - Verified md5 checksum > - Could not verify sha as i see the contents of > apache-falcon-0.6.1-sources.tar.gz.sha as binary . > - Saw some binary files, not sure if there was already any discussion > regarding inclusion : > > > ./falcon-ui/node_modules/grunt-contrib-less/node_modules/less/gradle/wrapper/gradle-wrapper.jar > > - Seeing licensing issues, again not sure if there was any discussion > regd them : > > ./falcon-sources-0.6.1/falcon-ui/app/test/lib/jasmine-2.0.2 is not > mentioned in top level icense. > > /falcon-ui/node_modules/ has lots of js files with different MIT licenses. > Not all of them are mentioned in top level license. > > > - Some minor issues : > > > ./falcon-sources-0.6.1/falcon-regression/merlin/src/test/resources/log4j.properties > has copyright tag > > > - Build issues > > ------ > I could not succeed with "mvn clean install -DskipTests " also. It was > bringing up jetty server and build did not succeed after that. > > SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory] > 2015-05-12 12:21:17.469:INFO::Started SslSocketConnector@0.0.0.0:41443 > 2015-05-12 12:21:18.066:INFO::Started SelectChannelConnector@0.0.0.0:41000 > [INFO] Started Jetty Server > [ERROR] > [INFO] > [INFO] --- maven-failsafe-plugin:2.16:integration-test (integration-test) > @ falcon-webapp --- > [INFO] Tests are skipped. > [INFO] > [INFO] --- maven-jetty-plugin:6.1.26:stop (stop-jetty) @ falcon-webapp --- > [INFO] > [INFO] --- maven-failsafe-plugin:2.16:verify (verify) @ falcon-webapp --- > [INFO] Tests are skipped. > [INFO] > [INFO] --- maven-install-plugin:2.3.1:install (default-install) @ > falcon-webapp --- > java.net.SocketException: Invalid argument > at java.net.PlainSocketImpl.socketAccept(Native Method) > at > java.net.AbstractPlainSocketImpl.accept(AbstractPlainSocketImpl.java:398) > at java.net.ServerSocket.implAccept(ServerSocket.java:522) > at java.net.ServerSocket.accept(ServerSocket.java:490) > at org.mortbay.jetty.plugin.util.Monitor.run(Monitor.java:74) > [ERROR] > java.net.SocketException: Invalid argument > at java.net.PlainSocketImpl.socketAccept(Native Method) > at > java.net.AbstractPlainSocketImpl.accept(AbstractPlainSocketImpl.java:398) > at java.net.ServerSocket.implAccept(ServerSocket.java:522) > at java.net.ServerSocket.accept(ServerSocket.java:490) > at org.mortbay.jetty.plugin.util.Monitor.run(Monitor.java:74) > > ----- > > Saw some test failures with mvn clean install. > > Running org.apache.falcon.entity.parser.FeedEntityParserTest > 2015-05-12 11:59:52.495 java[2770:1703] Unable to load realm mapping info > from SCDynamicStore > Tests run: 35, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 12.593 > sec <<< FAILURE! - in org.apache.falcon.entity.parser.FeedEntityParserTest > testValidateACLAndStorageForValidGroupBadOwner(org.apache.falcon.entity.parser.FeedEntityParserTest) > Time elapsed: 0.292 sec <<< FAILURE! > org.testng.TestException: > Method > org.apache.falcon.entity.parser.FeedEntityParserTest.testValidateACLAndStorageForValidGroupBadOwner() > should have thrown an exception of class > org.apache.falcon.entity.parser.ValidationException > at org.testng.internal.Invoker.handleInvocationResults(Invoker.java:1443) > at org.testng.internal.Invoker.invokeMethod(Invoker.java:722) > at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:842) > at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1166) > at > org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:125) > at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:109) > at org.testng.TestRunner.runWorkers(TestRunner.java:1178) > at org.testng.TestRunner.privateRun(TestRunner.java:757) > at org.testng.TestRunner.run(TestRunner.java:608) > at org.testng.SuiteRunner.runTest(SuiteRunner.java:334) > at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329) > at org.testng.SuiteRunner.privateRun(SuiteRunner.java:291) > at org.testng.SuiteRunner.run(SuiteRunner.java:240) > at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52) > at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86) > at org.testng.TestNG.runSuitesSequentially(TestNG.java:1158) > at org.testng.TestNG.runSuitesLocally(TestNG.java:1083) > at org.testng.TestNG.run(TestNG.java:999) > at > org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:91) > at > org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeSingleClass(TestNGDirectoryTestSuite.java:128) > at > org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:112) > at > org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:113) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) > at > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) > > testValidateACLValidGroupBadOwner(org.apache.falcon.entity.parser.FeedEntityParserTest) > Time elapsed: 0.333 sec <<< FAILURE! > org.testng.TestException: > Method > org.apache.falcon.entity.parser.FeedEntityParserTest.testValidateACLValidGroupBadOwner() > should have thrown an exception of class > org.apache.falcon.entity.parser.ValidationException > at org.testng.internal.Invoker.handleInvocationResults(Invoker.java:1443) > at org.testng.internal.Invoker.invokeMethod(Invoker.java:722) > at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:842) > at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1166) > at > org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:125) > at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:109) > at org.testng.TestRunner.runWorkers(TestRunner.java:1178) > at org.testng.TestRunner.privateRun(TestRunner.java:757) > at org.testng.TestRunner.run(TestRunner.java:608) > at org.testng.SuiteRunner.runTest(SuiteRunner.java:334) > at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329) > at org.testng.SuiteRunner.privateRun(SuiteRunner.java:291) > at org.testng.SuiteRunner.run(SuiteRunner.java:240) > at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52) > at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86) > at org.testng.TestNG.runSuitesSequentially(TestNG.java:1158) > at org.testng.TestNG.runSuitesLocally(TestNG.java:1083) > at org.testng.TestNG.run(TestNG.java:999) > at > org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:91) > at > org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeSingleClass(TestNGDirectoryTestSuite.java:128) > at > org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:112) > at > org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:113) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) > at > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) > > ---- > > Thanks > Amareshwari > > On Tue, May 12, 2015 at 11:01 AM, Venkat Ranganathan < > vranganat...@hortonworks.com> wrote: > >> Thanks for working on this. I verified the md5 sum and keys. One >> suggestion – it would be easy to provide a link to the KEYS file in future. >> >> >> I ran into the following test failure. >> >> ===------------------------------------------------------ >> T E S T S >> ------------------------------------------------------- >> Running org.apache.falcon.retention.FeedEvictorTest >> Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 4.082 sec >> <<< FAILURE! - in org.apache.falcon.retention.FeedEvictorTest >> testEvictionWithEmptyDirs(org.apache.falcon.retention.FeedEvictorTest) >> Time elapsed: 0.22 sec <<< FAILURE! >> java.lang.AssertionError: expected:<true> but was:<false> >> at org.testng.Assert.fail(Assert.java:89) >> at org.testng.Assert.failNotEquals(Assert.java:489) >> at org.testng.Assert.assertTrue(Assert.java:37) >> at org.testng.Assert.assertTrue(Assert.java:47) >> at >> org.apache.falcon.retention.FeedEvictorTest.testEvictionWithEmptyDirs(FeedEvictorTest.java:404) >> >> >> Results : >> >> Failed tests: >> FeedEvictorTest.testEvictionWithEmptyDirs:404 expected:<true> but >> was:<false> >> >> Tests run: 9, Failures: 1, Errors: 0, Skipped: 0 >> >> === >> >> >> Venkat >> >> From: Idris Ali >> Reply-To: "dev@falcon.apache.org<mailto:dev@falcon.apache.org>" >> Date: Monday, May 11, 2015 at 10:29 AM >> To: "dev@falcon.apache.org<mailto:dev@falcon.apache.org>" >> Subject: [VOTE] Release of Apache Falcon 0.6.1 - RC0 >> >> Hi Folks, >> >> We are ready with our first Falcon TLP release candidate. Kudos! >> >> Release package for Falcon 0.6.1 is now available after resolving few >> issues identified while testing 0.6.1 branch. >> This is a big release in terms of introduction of new features and bug >> fixes. Thanks to all the contributors and the new committers. >> >> The source tar ball, signature and checksum files can be downloaded from: >> https://dist.apache.org/repos/dist/dev/falcon/apache-falcon-0.6.1-sources/ >> >> Checksums generated from pGpg. >> MD5 checksum: 98 65 74 C7 5D A4 39 3A 9D 6E 5C 38 BC FE 2E 39 >> SHA512 checksum: 72009EEB 393FD779 350B6669 8ED1B6F0 E897E172 86859059 >> 165F701F 992FF442 9A1E5578 8917FD60 182F4780 916070BD 8CE512BD DB09C9D1 >> 29F9B1BC 31D2E713 >> >> To verify signature: >> >gpg --verify apache-falcon-0.6.1-sources.tar.gz.asc >> apache-falcon-0.6.1-sources.tar.gz >> >> Git tag for the release: >> >> https://git-wip-us.apache.org/repos/asf?p=falcon.git;a=tag;h=refs/tags/release-0.6.1-rc0 >> >> We have closed around 200 JIRAs as part of this release. The details of >> which can be found here: >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12329086&styleName=Html&projectId=12314429 >> >> Please find attached the release document with this mail with brief >> explanation on new features. >> And please vote on the release. Vote will expire on May 15, 2015 12:00AM >> IST. >> >> [ ] +1 approve >> [ ] +0 no opinion >> [ ] -1 disapprove (and reason why) >> >> +1 from my side, >> >> Thanks, >> -Shaik Idris >> >> >> >> >> >> >> >> >> >> >> >
