----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38005/#review97393 -----------------------------------------------------------
prism/src/main/java/org/apache/falcon/FalconWebException.java (line 103) <https://reviews.apache.org/r/38005/#comment153283> Why not just return e.getMessage()? Unnecessary construction of StringWriter(). Also, it would be good to add not just the message on the exception, but, the message from the cause. - Pallavi Rao On Sept. 1, 2015, 12:55 p.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38005/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2015, 12:55 p.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > IMO, we should just return a good error message. The stack trace shouldn't > really be the users concern. > > > Diffs > ----- > > prism/src/main/java/org/apache/falcon/FalconWebException.java d9a3be7 > > Diff: https://reviews.apache.org/r/38005/diff/ > > > Testing > ------- > > Done > > > Thanks, > > Narayan Periwal > >
