> On Sept. 16, 2015, 2:57 p.m., Venkat Ranganathan wrote: > > client/src/main/resources/feed-0.1.xsd, line 322 > > <https://reviews.apache.org/r/38105/diff/6/?file=1073912#file1073912line322> > > > > Instead of limit, do you think level is a better terminology? Or may > > be trigger, but that sounds too heavy. > > For example > > level="attempt" or level = "instance"
done. > On Sept. 16, 2015, 2:57 p.m., Venkat Ranganathan wrote: > > client/src/main/resources/feed-0.1.xsd, line 326 > > <https://reviews.apache.org/r/38105/diff/6/?file=1073912#file1073912line326> > > > > Would suggest instance instead of final done. - Peeyush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38105/#review99222 ----------------------------------------------------------- On Sept. 15, 2015, 3:11 p.m., Peeyush Bishnoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38105/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2015, 3:11 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1425 > https://issues.apache.org/jira/browse/FALCON-1425 > > > Repository: falcon-git > > > Description > ------- > > Provide Email based notification plugin to send notification when Falcon > instance completes. > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/entity/v0/EntityNotification.java > PRE-CREATION > client/src/main/resources/feed-0.1.xsd 4ff8baa > client/src/main/resources/jaxb-binding.xjb f644f40 > client/src/main/resources/process-0.1.xsd c81d6f7 > common/src/main/java/org/apache/falcon/entity/EntityUtil.java 2f05b1f > common/src/main/resources/startup.properties 0593b96 > > common/src/test/java/org/apache/falcon/entity/parser/FeedEntityParserTest.java > 754fb06 > > common/src/test/java/org/apache/falcon/entity/parser/ProcessEntityParserTest.java > 6612b74 > common/src/test/resources/config/feed/feed-0.1.xml 6448803 > common/src/test/resources/config/process/process-0.1.xml 2659903 > metrics/pom.xml 748fb97 > metrics/src/main/java/org/apache/falcon/plugin/NotificationPlugin.java > PRE-CREATION > metrics/src/main/java/org/apache/falcon/util/EmailNotificationProps.java > PRE-CREATION > metrics/src/main/java/org/apache/falcon/util/NotificationType.java > PRE-CREATION > prism/pom.xml be04ac9 > prism/src/main/java/org/apache/falcon/plugin/EmailNotification.java > PRE-CREATION > prism/src/main/java/org/apache/falcon/plugin/EmailNotificationPlugin.java > PRE-CREATION > prism/src/main/java/org/apache/falcon/plugin/NotificationHandler.java > PRE-CREATION > prism/src/main/java/org/apache/falcon/util/NotificationUtil.java > PRE-CREATION > prism/src/test/java/org/apache/falcon/plugin/EmailNotificationTest.java > PRE-CREATION > src/conf/startup.properties ca55689 > > Diff: https://reviews.apache.org/r/38105/diff/ > > > Testing > ------- > > Yes, manual testing has been done for this after configuring > startup.properties with SMTP properties. > Also test cases has been added to test Falcon feed/process entity with > notification tag. > Unit test has been added to test Email Notification. > > > Thanks, > > Peeyush Bishnoi > >
