> On Sept. 24, 2015, 5:32 a.m., sandeep samudrala wrote: > > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java, > > line 57 > > <https://reviews.apache.org/r/38707/diff/1/?file=1083817#file1083817line57> > > > > FEED SLA?
I wanted it to be generic like other loggers and probably reuse it later for process sla monitoring as well. > On Sept. 24, 2015, 5:32 a.m., sandeep samudrala wrote: > > src/conf/log4j.xml, line 59 > > <https://reviews.apache.org/r/38707/diff/1/?file=1083818#file1083818line59> > > > > %t(thread id) not required? I don't think so, not many threads at play which need distinction. > On Sept. 24, 2015, 5:32 a.m., sandeep samudrala wrote: > > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java, > > line 191 > > <https://reviews.apache.org/r/38707/diff/1/?file=1083817#file1083817line191> > > > > Not related to this change. In case of property not being set in > > startup.properties, will not the service fail and throw falcon exception? I didn't understand the context from your comment. However, if there are no reasonable and intuitive defaults then it is probably the best thing to do. - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38707/#review100365 ----------------------------------------------------------- On Sept. 24, 2015, 8:54 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38707/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2015, 8:54 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1472 > https://issues.apache.org/jira/browse/FALCON-1472 > > > Repository: falcon-git > > > Description > ------- > > Apart from the current issue, this patch also addresses the following issues: > 1) FALCON-1474 > 2) FALCON-1475 > It also adds one more enhancement to DeploymentUtil where colo should be > ignored in embedded mode. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/util/DeploymentUtil.java 5d65073 > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java > 37aa9e6 > src/conf/log4j.xml 1341c6e > > Diff: https://reviews.apache.org/r/38707/diff/ > > > Testing > ------- > > Logging and Deployment issues. Verified manually. > > > Thanks, > > Ajay Yadava > >
