> On Sept. 25, 2015, 5:30 a.m., Peeyush Bishnoi wrote: > > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java, > > line 57 > > <https://reviews.apache.org/r/38707/diff/2/?file=1084263#file1084263line57> > > > > As this SLA monitoring service belongs for Feed, can we more > > specifically say "FeedSLA" instead of just "SLA". > > Ajay Yadava wrote: > Same Logger can be used by other sla services as well. Do you think it > will be better to have feed and process sla logs separately? > > Peeyush Bishnoi wrote: > I am of the opinion that Feed and Process are different entities. They > both are shedulable. Both will have different SLA’s while their instance > executes. So if we have same logger for both, we could not able to > differentiate much. Due to this, I suggested to have FeedSLA for this > FeedSLAMonitoringService.
Based on suggestions from everyone I decided to take the safer approach of separating out the feed sla logs and used "FeedSLA". Thank you everyone. - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38707/#review100529 ----------------------------------------------------------- On Sept. 25, 2015, 11:05 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38707/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2015, 11:05 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1472 > https://issues.apache.org/jira/browse/FALCON-1472 > > > Repository: falcon-git > > > Description > ------- > > Apart from the current issue, this patch also addresses the following issues: > 1) FALCON-1474 > 2) FALCON-1475 > It also adds one more enhancement to DeploymentUtil where colo should be > ignored in embedded mode. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/util/DeploymentUtil.java 5d65073 > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java > 37aa9e6 > src/conf/log4j.xml 1341c6e > > Diff: https://reviews.apache.org/r/38707/diff/ > > > Testing > ------- > > Logging and Deployment issues. Verified manually. > > > Thanks, > > Ajay Yadava > >
