> On Sept. 30, 2015, 12:31 p.m., PRAGYA MITTAL wrote: > > lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedWorkflowBuilder.java, > > line 86 > > <https://reviews.apache.org/r/38861/diff/2/?file=1087689#file1087689line86> > > > > Currently retention uses the feed level properties if set.IMO, for > > lifecycle also priority and queue should honour the feedLevelProperty if > > set in feed.
Its honoring as feed level properties - sandeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38861/#review101110 ----------------------------------------------------------- On Sept. 30, 2015, 8:07 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38861/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2015, 8:07 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1499 > https://issues.apache.org/jira/browse/FALCON-1499 > > > Repository: falcon-git > > > Description > ------- > > Two issues: > 1) Some properties were missing from startup.properties > 2) NullPointerException when queueName and priority are not specified in > retentionStage. > Originally reported by Pragya Mittal. > > > Diffs > ----- > > common/src/main/resources/startup.properties 3383129 > > lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedCoordinatorBuilder.java > 4601070 > > lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedWorkflowBuilder.java > 0a87213 > src/conf/startup.properties 8e4ce97 > > Diff: https://reviews.apache.org/r/38861/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
