[ 
https://issues.apache.org/jira/browse/FALCON-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958953#comment-14958953
 ] 

Pragya Mittal edited comment on FALCON-1541 at 10/15/15 2:05 PM:
-----------------------------------------------------------------

[~pallavi.rao] [~pavan kumar]  +1 for the approach. I have one concern. 
Currently, when falcon is deployed in distributed mode deploy.properties is 
packaged internally in prism.war only. 

{noformat}
pragya@8RPCG32:~/WORKSPACE/trial-falcon/prism/server/webapp/prism/WEB-INF/classes$
 ls
builddef.lst  deploy.properties  falcon-buildinfo.properties  log4j.xml  
META-INF  org

{noformat}

Server uses falcon-prism-(falcon.version)-classes.jar to access these 
properties. It does not bundle deploy.properties explicitly in its war. 
{noformat}
pragya@8RPCG32:~/WORKSPACE/trial-falcon/server/server/webapp/falcon/WEB-INF/classes$
 ls
client.properties  falcon-buildinfo.properties  log4j.xml  META-INF  org

pragya@8RPCG32:~/WORKSPACE/trial-falcon/server/server/webapp/falcon/WEB-INF/lib$
 ls | grep prism
falcon-prism-0.8-SNAPSHOT-classes.jar

{noformat}

Although, I feel this is a hackaround and we should bundle falcon.war with its 
own deploy.properties. Thoughts please.


was (Author: pragya.mittal):
[~pallavi.rao] [~pavan kumar]  +1 for the approach. I have one concern. 
Currently, when falcon is deployed in distributed mode deploy.properties is 
packaged internally in prism.war only. 

{noformat}
pragya@8RPCG32:~/WORKSPACE/trial-falcon/prism/server/webapp/prism/WEB-INF/classes$
 ls
builddef.lst  deploy.properties  falcon-buildinfo.properties  log4j.xml  
META-INF  org

{noformat}

Server uses falcon-prism-{falcon.version}-classes.jar to access these 
properties. It does not bundle deploy.properties explicitly in its war. 
{noformat}
pragya@8RPCG32:~/WORKSPACE/trial-falcon/server/server/webapp/falcon/WEB-INF/classes$
 ls
client.properties  falcon-buildinfo.properties  log4j.xml  META-INF  org

pragya@8RPCG32:~/WORKSPACE/trial-falcon/server/server/webapp/falcon/WEB-INF/lib$
 ls | grep prism
falcon-prism-0.8-SNAPSHOT-classes.jar

{noformat}

Although, I feel this is a hackaround and we should bundle falcon.war with its 
own deploy.properties. Thoughts please.

> Bundle deploy.properties while packaging falcon
> -----------------------------------------------
>
>                 Key: FALCON-1541
>                 URL: https://issues.apache.org/jira/browse/FALCON-1541
>             Project: Falcon
>          Issue Type: Bug
>    Affects Versions: 0.8
>         Environment: QA
>            Reporter: Pragya Mittal
>            Assignee: Pragya Mittal
>         Attachments: FALCON-1541.patch
>
>
> Currently falcon is packaged in a way that deploy.properties are not a part 
> of bundle. So when we deploy falcon in distributed mode, falcon has no way of 
> knowing which mode it is in,thus considering embedded mode which is default 
> by nature. This was discovered while testing FALCON-1515 and FALCON-1526. IMO 
> falcon should bundle deploy.properties while packaging and handle the 
> configurations depending on the mode of deployment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to