> On Oct. 16, 2015, 11:34 a.m., PRAGYA MITTAL wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessUpdateTest.java, > > line 79 > > <https://reviews.apache.org/r/39391/diff/1/?file=1099888#file1099888line79> > > > > Can we add this use case as a part of NewPrismProcessUpdateTest.
NewPrismProcessUpdateTest is fully "distributed" test class, so didn't add "embedded" test to it. > On Oct. 16, 2015, 11:34 a.m., PRAGYA MITTAL wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java, > > line 286 > > <https://reviews.apache.org/r/39391/diff/1/?file=1099886#file1099886line286> > > > > Is it the only case with respect to triage api? yes > On Oct. 16, 2015, 11:34 a.m., PRAGYA MITTAL wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java, > > line 68 > > <https://reviews.apache.org/r/39391/diff/1/?file=1099886#file1099886line68> > > > > FeedInstanceDependencyTest, ProcessInstanceDependencyTest are already > > present as part of FALCON-1039. Can we add any missing cases over there if > > required intead of adding a whole new test. InstanceDependencyTest launches pipeline scenario of 3 processes and tests dependecy API on this basis which seems a bit different from what FeedInstanceDependencyTest and ProcessInstanceDependencyTest do. May we rename InstanceDependencyTest to something like PipelineInstanceDependencyTest and left it as is to avoid repeating scenario preparation in different classes? - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39391/#review102905 ----------------------------------------------------------- On Oct. 16, 2015, 10:24 a.m., Paul Isaychuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39391/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2015, 10:24 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1546 > https://issues.apache.org/jira/browse/FALCON-1546 > > > Repository: falcon-git > > > Description > ------- > > Set of new tests and test fixes > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java > ba1d228 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java > b905bee > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java > 83d06a2 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java > 10463c2 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/KerberosHelper.java > 9d028fa > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java > 83547e7 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java > d956549 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java > 0fbfc38 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/EntityWizardPage.java > PRE-CREATION > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java > f3a107c > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/LoginPage.java > 3193d21 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/MirrorWizardPage.java > 6dfa1ca > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java > 2a75b20 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ProcessWizardPage.java > 706328f > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java > 0662562 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java > 9ac9f24 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java > 7f1e445 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessUpdateTest.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java > 9ea8471 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDRTest.java > 1c788a3 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDbDRTest.java > a64bd6d > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/RecipeExecLocation.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java > be8a631 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java > b0ddcf3 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java > 47b1d19 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/HomePageTest.java > 20864f6 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSourceTargetOptionsTest.java > 552c15e > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorTest.java > c54789b > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ProcessSetupTest.java > 728646f > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java > d11411b > > Diff: https://reviews.apache.org/r/39391/diff/ > > > Testing > ------- > > > Thanks, > > Paul Isaychuk > >
