----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39711/#review104251 -----------------------------------------------------------
common/src/main/java/org/apache/falcon/entity/FeedHelper.java (line 810) <https://reviews.apache.org/r/39711/#comment162528> In case of TimeUnit being minutes, if its 10 minutes, the frequency would be set to 10 hours. common/src/test/java/org/apache/falcon/entity/parser/FeedEntityParserTest.java (line 204) <https://reviews.apache.org/r/39711/#comment162529> Can you change the test to test it for a frequency less than 6 hours , something in minutes? - sandeep samudrala On Oct. 28, 2015, 5:15 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39711/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2015, 5:15 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1560 > https://issues.apache.org/jira/browse/FALCON-1560 > > > Repository: falcon-git > > > Description > ------- > > Lifecycle does not allow feed with frequency greater than days(1) > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java 5c252a8 > > common/src/test/java/org/apache/falcon/entity/parser/FeedEntityParserTest.java > 905be68 > > Diff: https://reviews.apache.org/r/39711/diff/ > > > Testing > ------- > > Added unit test for the scenarios. > > > Thanks, > > Ajay Yadava > >
