> On Nov. 3, 2015, 1:53 p.m., Ajay Yadava wrote: > > This is a very useful feature and it will be really helpful to document > > these options in schedule api with an example.
Hi Ajay, I'd like to add an example showing the entity XML and how to reference the properties passed on schedule (kind of similar to what's in Jira) but I'm not sure if EntitySchedule.twiki is the best place for this. Can you advise please? - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39812/#review104910 ----------------------------------------------------------- On Nov. 4, 2015, 3:38 p.m., Daniel del Castillo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39812/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2015, 3:38 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1573 > https://issues.apache.org/jira/browse/FALCON-1573 > > > Repository: falcon-git > > > Description > ------- > > Make user-defined properties passed in the entity sechdule service available > in the configuration of the coordinator job so they can be used in the > workflow. Please see Jira ticket for further details. > > > Diffs > ----- > > CHANGES.txt ebb22cd97e0e89c14bbc11e6a76bae1fb25a808e > docs/src/site/twiki/FalconCLI.twiki > e001a7f34977a4d84c5f45d5517dfbfb898d862d > docs/src/site/twiki/restapi/EntitySchedule.twiki > 263d1523c20c3f7b78d4ae2b1cba2eb4904977f2 > oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java > e0af30deb355b58ad8edab5b1fd7129944838ac8 > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > 7262964c17ec9465099066e359772580792d06a3 > > oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java > 5e930272864aebe44cae0eea2eb85977fbeeb6cf > > oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java > 9f492d7b22001dd016e5d2ca12909d84d3a0c5f4 > > Diff: https://reviews.apache.org/r/39812/diff/ > > > Testing > ------- > > UT added. > Manual functional testing done. > > > Thanks, > > Daniel del Castillo > >
