-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40121/
-----------------------------------------------------------
(Updated Nov. 15, 2015, 6:21 p.m.)
Review request for Falcon, Ajay Yadava, Sowmya Ramesh, and Venkat Ranganathan.
Changes
-------
This patch incorporates Ajay's suggestion. Granularity at level of SECONDs is
removed.
Bugs: Falcon-1372
https://issues.apache.org/jira/browse/Falcon-1372
Repository: falcon-git
Description
-------
The bug is caused due to the way java.util.Calendar handles DAY_OF_MONTH. In
FeedHelper, the getDate(...) method sets DAY_OF_MONTH to 0 for date patterns
like ${YEAR}/${MONTH}.
This causes the month to be setback by 1. So "2015/11" will be treated as Oct
31st, 2015. Hence this instance will be evicted. For a date like "2015/11" ,
Calender should be set to cal.set(2015, 10, 1, 0, 0, 0); The MONTH should be
"value - 1" and The DAY_OF_MONTH begins with a 1 instead of 0.
Diffs (updated)
-----
common/src/main/java/org/apache/falcon/entity/FeedHelper.java 8c55e41
common/src/main/java/org/apache/falcon/entity/common/FeedDataPath.java
afe913d
common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 10dac49
Diff: https://reviews.apache.org/r/40121/diff/
Testing
-------
Testing done end2end, added few more test cases to verify getDate() method in
FeedHelper works as expected.
Thanks,
Balu Vellanki
