> On Nov. 4, 2015, 6:44 p.m., Ajay Yadava wrote: > > scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java, line 107 > > <https://reviews.apache.org/r/39588/diff/2/?file=1114735#file1114735line107> > > > > I think this is not what you want. Two objects which are equal must > > return the same hashcode, which is not guaranteed by this implementation. > > pavan kumar kolamuri wrote: > As i said above will explain you about this
I removed all this methods and refactored ExecutionInstance and Predicate Class. Please review. > On Nov. 4, 2015, 6:44 p.m., Ajay Yadava wrote: > > scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java, line 293 > > <https://reviews.apache.org/r/39588/diff/2/?file=1114735#file1114735line293> > > > > Interesting. I strongly suspect that all this is required only because > > of that one wrong hashcode implementation :) > > pavan kumar kolamuri wrote: > Agreed will discuss with this offline Here hashcode is different for different objects. But while comparing ExecutionInstances we are comparing lists by sorting. I don't think simple hash code of list will work. Please correct me if i am wrong. > On Nov. 4, 2015, 6:44 p.m., Ajay Yadava wrote: > > scheduler/src/main/java/org/apache/falcon/state/store/EntityStateStore.java, > > line 82 > > <https://reviews.apache.org/r/39588/diff/2/?file=1114738#file1114738line82> > > > > This is a potentially risky method. I can't imagine a scenario where it > > will be useful in production environments. Is it just for tests? > > pavan kumar kolamuri wrote: > Yes it is just for tests This i fixed . It will run only in tests in prod it will throw exception. - pavan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39588/#review105038 ----------------------------------------------------------- On Nov. 13, 2015, 5:18 a.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39588/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2015, 5:18 a.m.) > > > Review request for Falcon. > > > Bugs: https://issues.apache.org/jira/browse/FALCON-1234 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FALCON-1234 > > > Repository: falcon-git > > > Description > ------- > > Persistent State Store for Falcon Native Scheduler > > > Diffs > ----- > > checkstyle/src/main/resources/falcon/checkstyle.xml 2130e73 > checkstyle/src/main/resources/falcon/findbugs-exclude.xml 0a7580d > common/src/main/resources/startup.properties cc5212a > pom.xml 6f2c480 > scheduler/pom.xml 20a91d2 > scheduler/src/main/java/org/apache/falcon/execution/ExecutionInstance.java > 3869ff2 > > scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java > b959320 > > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java > 8c84f2b > scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java fb4c8c9 > scheduler/src/main/java/org/apache/falcon/state/EntityState.java 15aea9a > scheduler/src/main/java/org/apache/falcon/state/ID.java 420c856 > scheduler/src/main/java/org/apache/falcon/state/InstanceState.java 8cf24ee > scheduler/src/main/java/org/apache/falcon/state/StateService.java 81357a4 > > scheduler/src/main/java/org/apache/falcon/state/store/AbstractStateStore.java > ba3d5fd > scheduler/src/main/java/org/apache/falcon/state/store/EntityStateStore.java > 4aa6fdb > > scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java > 3822860 > > scheduler/src/main/java/org/apache/falcon/state/store/InstanceStateStore.java > d6a4b49 > scheduler/src/main/java/org/apache/falcon/state/store/StateStore.java > f595c26 > > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/BeanMapperUtil.java > PRE-CREATION > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/EntityBean.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/state/store/service/FalconJPAService.java > PRE-CREATION > scheduler/src/main/java/org/apache/falcon/tools/FalconStateStoreDBCLI.java > PRE-CREATION > scheduler/src/main/resources/META-INF/persistence.xml PRE-CREATION > scheduler/src/main/resources/falcon-buildinfo.properties PRE-CREATION > > scheduler/src/test/java/org/apache/falcon/execution/FalconExecutionServiceTest.java > b2f9e59 > > scheduler/src/test/java/org/apache/falcon/notification/service/SchedulerServiceTest.java > b4a0f35 > > scheduler/src/test/java/org/apache/falcon/state/AbstractSchedulerTestBase.java > PRE-CREATION > scheduler/src/test/java/org/apache/falcon/state/EntityStateServiceTest.java > 2f32b43 > > scheduler/src/test/java/org/apache/falcon/state/InstanceStateServiceTest.java > d27ac7e > > scheduler/src/test/java/org/apache/falcon/state/service/TestFalconJPAService.java > PRE-CREATION > > scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java > PRE-CREATION > > scheduler/src/test/java/org/apache/falcon/tools/TestFalconStateStoreDBCLI.java > PRE-CREATION > scheduler/src/test/resources/startup.properties PRE-CREATION > src/bin/falcon-db.sh PRE-CREATION > src/conf/startup.properties ce6e91f > src/main/assemblies/distributed-package.xml 794eaef > src/main/assemblies/standalone-package.xml fcff8d7 > unit/src/main/resources/startup.properties fe6f430 > > Diff: https://reviews.apache.org/r/39588/diff/ > > > Testing > ------- > > I have written unit tests. I will also test externally by setting up > everything > > > Thanks, > > pavan kumar kolamuri > >
