> On Dec. 2, 2015, 4:53 a.m., Peeyush Bishnoi wrote: > > prism/src/main/java/org/apache/falcon/handler/SLAMonitoringHandler.java, > > line 40 > > <https://reviews.apache.org/r/40540/diff/1/?file=1134482#file1134482line40> > > > > With this Handler service another SLA monitoring service will be > > provided. Should not be SLAMonitoringHandler and FeedSLAMonitoringService > > be part of one service and required functionality must be achieved.
The way I see it is - one core part for SLA (FeedSLAMonitoringService) and then there are notifiers which can send feed availability signals. These signals can grow (e.g. we can add another service which leverages inotify) and hence it might make sense to keep them separate just from maintenance perspective. > On Dec. 2, 2015, 4:53 a.m., Peeyush Bishnoi wrote: > > src/conf/startup.properties, line 94 > > <https://reviews.apache.org/r/40540/diff/1/?file=1134485#file1134485line94> > > > > Any particular reason for SLAMonitoringHanlder service to be set for > > "workflow.execution.listeners" rather than "application.services". As this > > is also one of the service and all the Falcon services are part of > > "application.services". I am guessing it is to ensure that it is registered as one of the listeners for workflow end notifications, which will not be possible if it is mentioned in "application.services". - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40540/#review108603 ----------------------------------------------------------- On Nov. 20, 2015, 12:37 p.m., sandeep samudrala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40540/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2015, 12:37 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1616 > https://issues.apache.org/jira/browse/FALCON-1616 > > > Repository: falcon-git > > > Description > ------- > > We can leverage workflow job finish notifications and update feed > availability so that SLA monitoring service doesn't need to check for it. > > > Diffs > ----- > > prism/src/main/java/org/apache/falcon/handler/SLAMonitoringHandler.java > PRE-CREATION > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java > d4383ec > prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java > ca55d01 > src/conf/startup.properties ce6e91f > > Diff: https://reviews.apache.org/r/40540/diff/ > > > Testing > ------- > > Unit Tests > > > Thanks, > > sandeep samudrala > >
