----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38882/#review110634 -----------------------------------------------------------
client/src/main/java/org/apache/falcon/cli/FalconInstanceCLI.java (line 155) <https://reviews.apache.org/r/38882/#comment170635> to get all attempts of corresponding instances. docs/src/site/twiki/FalconCLI.twiki (line 282) <https://reviews.apache.org/r/38882/#comment170639> end user doesn't understant run-id. Change it to "To get all the attempts for corresponding instances." docs/src/site/twiki/FalconCLI.twiki (line 283) <https://reviews.apache.org/r/38882/#comment170638> Add a line over here. docs/src/site/twiki/restapi/InstanceList.twiki (line 28) <https://reviews.apache.org/r/38882/#comment170640> same here. As now with oozie not creating a new workflow whil e normal falcon retry or rerun, the attempts are gettable from oozie only when there are force reruns. Document accordingly to let user understand that the attempts of full forced runs are only available. oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java (line 678) <https://reviews.apache.org/r/38882/#comment170648> instance1 is not used anywhere else? - sandeep samudrala On Oct. 27, 2015, 9:54 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38882/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2015, 9:54 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1495 > https://issues.apache.org/jira/browse/FALCON-1495 > > > Repository: falcon-git > > > Description > ------- > > Most of the times , when there are failures in the pipelines, retries run and > the workflows might have got succeeded in sub sequential retry. But for end > user to figure out why it has failed initially might be useful to understand > for failures handling and SLA misses. > > As of now to figure out the same, its a tedious task to get such information > by either going through oozie DB/logs or via the logs backed up in hdfs by > the falcon postprocessing(which is 100% reliable as in few cases, falcon post > processing might fail or for some reason if it couldn't back up the logs). > > In either case, Falcon should abstract the oozie client layer to be used by > end user, and support all runs status to end user. > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconInstanceCLI.java 6ea34da > client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java > 91d5324 > client/src/main/java/org/apache/falcon/client/FalconClient.java 27510f6 > > common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java > 8b3460a > docs/src/site/twiki/FalconCLI.twiki d994866 > docs/src/site/twiki/restapi/InstanceList.twiki 229d6f9 > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > 09c29ab > prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java > 606f741 > > prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java > d317aa1 > > prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java > 96c99f0 > > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java > 8dcf3a5 > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java b5afae3 > unit/src/main/java/org/apache/falcon/unit/LocalInstanceManager.java 1503b28 > unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java ac478f4 > webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java > 76c66f3 > > Diff: https://reviews.apache.org/r/38882/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > Narayan Periwal > >
