----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41568/#review111281 -----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java (line 826) <https://reviews.apache.org/r/41568/#comment171375> coordinatorJob.getAppName().startsWith("FALCON_FEED_RETENTION") falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java (line 827) <https://reviews.apache.org/r/41568/#comment171377> why create coord again? falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java (line 828) <https://reviews.apache.org/r/41568/#comment171378> return null upon if its not retention falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java (line 829) <https://reviews.apache.org/r/41568/#comment171379> why return null? don't consider for else at all. Return null at the end if retention coordinator not found falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java (line 304) <https://reviews.apache.org/r/41568/#comment171381> comment is unclear. Do you mean having minutely lifecycle retention frequency. It would fail since lifecycle retention frequency has to be >= 1 hour. falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java (line 311) <https://reviews.apache.org/r/41568/#comment171392> latearrival and cutoff not required for this test falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java (line 361) <https://reviews.apache.org/r/41568/#comment171393> same here falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java (line 373) <https://reviews.apache.org/r/41568/#comment171395> } else if (!globalWithStage) { same as else ? falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java (line 382) <https://reviews.apache.org/r/41568/#comment171396> } else if (!clusterWithStage) { same as else ? - sandeep samudrala On Dec. 18, 2015, 9:44 p.m., PRAGYA MITTAL wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41568/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2015, 9:44 p.m.) > > > Review request for Falcon and Ajay Yadava. > > > Bugs: FALCON-1567 > https://issues.apache.org/jira/browse/FALCON-1567 > > > Repository: falcon-git > > > Description > ------- > > Add test cases for https://issues.apache.org/jira/browse/FALCON-965 > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java > ae96044 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java > 8f45d1c > > Diff: https://reviews.apache.org/r/41568/diff/ > > > Testing > ------- > > Tested. > > > Thanks, > > PRAGYA MITTAL > >
