> On Dec. 23, 2015, 9:37 a.m., Ajay Yadava wrote: > > common/src/main/resources/statestore.properties, line 28 > > <https://reviews.apache.org/r/41605/diff/1/?file=1173799#file1173799line28> > > > > Shouldn't this be 600 so that users can actually update the credentials > > also? This is what is followed by postgres as well. > > > > http://www.postgresql.org/docs/8.1/static/libpq-pgpass.html
I discussed with srikanth regarding this, we agreed if some one wants to update , the file can be deleted by sudo and put new file with credentials. Still we can discuss on this 600 also works fine, anyway its upto users to decide Falcon is not mandating on that - pavan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41605/#review111758 ----------------------------------------------------------- On Dec. 21, 2015, 12:58 p.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41605/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2015, 12:58 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1601 > https://issues.apache.org/jira/browse/FALCON-1601 > > > Repository: falcon-git > > > Description > ------- > > We are bringing Falcon state Store DB for Native Scheduler as part of > https://issues.apache.org/jira/browse/FALCON-1234, We need to add more > secureness by removing password properties from startup props and also made > this Statestore supports Mysql as well. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/util/ApplicationProperties.java > 1d8cf49 > common/src/main/java/org/apache/falcon/util/StateStoreProperties.java > PRE-CREATION > common/src/main/resources/statestore.properties PRE-CREATION > docs/src/site/twiki/FalconNativeScheduler.twiki 9403ae7 > > scheduler/src/main/java/org/apache/falcon/state/store/AbstractStateStore.java > 2d576e5 > > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java > 151c2c2 > > scheduler/src/main/java/org/apache/falcon/state/store/service/FalconJPAService.java > 72d1aba > scheduler/src/main/java/org/apache/falcon/tools/FalconStateStoreDBCLI.java > f4058c8 > > scheduler/src/test/java/org/apache/falcon/notification/service/SchedulerServiceTest.java > 5a66518 > > scheduler/src/test/java/org/apache/falcon/state/AbstractSchedulerTestBase.java > a8be06d > scheduler/src/test/java/org/apache/falcon/state/EntityStateServiceTest.java > 6676754 > > scheduler/src/test/java/org/apache/falcon/state/InstanceStateServiceTest.java > f0ae7b2 > > scheduler/src/test/java/org/apache/falcon/workflow/engine/WorkflowEngineFactoryTest.java > 7e502cd > scheduler/src/test/resources/startup.properties 2e938ee > scheduler/src/test/resources/statestore.credentials PRE-CREATION > scheduler/src/test/resources/statestore.properties PRE-CREATION > src/conf/startup.properties ef0a2d5 > src/conf/statestore.properties PRE-CREATION > > webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java > 5001fe6 > webapp/src/test/resources/statestore.properties PRE-CREATION > > Diff: https://reviews.apache.org/r/41605/diff/ > > > Testing > ------- > > Manual Testing done > > > Thanks, > > pavan kumar kolamuri > >
