> On Jan. 12, 2016, 8:22 a.m., pavan kumar kolamuri wrote:
> > checkstyle/src/main/resources/falcon/findbugs-exclude.xml, line 52
> > <https://reviews.apache.org/r/42180/diff/1/?file=1193863#file1193863line52>
> >
> >     Instead of adding here can't we fix these ?

As of now, we are not fixing these, as we dont know any aide-effects of the 
changes. May be we can open a separate jira to fix these changes.


- Narayan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42180/#review113945
-----------------------------------------------------------


On Jan. 12, 2016, 6:10 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42180/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2016, 6:10 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1733
>     https://issues.apache.org/jira/browse/FALCON-1733
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Currently, the falcon build fails with JDK 1.8. This is because many of the 
> plugins still points to the older version, which will need to be updated.
> 
> 
> Diffs
> -----
> 
>   checkstyle/src/main/resources/falcon/findbugs-exclude.xml e1a5a2e 
>   client/src/main/java/org/apache/falcon/entity/v0/Frequency.java a9e4b90 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 575ceb3 
>   
> common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java
>  cf27408 
>   common/src/main/java/org/apache/falcon/util/HdfsClassLoader.java 3f9091f 
>   metrics/src/main/java/org/apache/falcon/aspect/AbstractFalconAspect.java 
> b24292c 
>   
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java
>  49fb4f7 
>   
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java
>  07eb47c 
>   oozie/src/main/java/org/apache/oozie/client/ProxyOozieClient.java fcd8ca7 
>   pom.xml 39ee9ac 
>   prism/src/main/java/org/apache/falcon/FalconServer.java d50ebe5 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 
> c32123d 
>   prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 
> 8ffecd8 
>   replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java 
> e97e84e 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
>  bffdb0b 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 
> 1d0e126 
>   
> test-tools/hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java
>  7bee592 
> 
> Diff: https://reviews.apache.org/r/42180/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Reply via email to