> On Jan. 18, 2016, 6:49 p.m., Ajay Yadava wrote: > > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java, > > line 399 > > <https://reviews.apache.org/r/42188/diff/1/?file=1194070#file1194070line399> > > > > What is the advantage of calling getIncludedClusters here? It seems > > that it will always return a blank list in this case with no side effects > > either?
None. Just remnant of copy-paste from another method :-). Will remove. - Pallavi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42188/#review115042 ----------------------------------------------------------- On Jan. 12, 2016, 10:14 a.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42188/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 10:14 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1742 > https://issues.apache.org/jira/browse/FALCON-1742 > > > Repository: falcon-git > > > Description > ------- > > This was not implemented. > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/resource/EntitySummaryResult.java > 4a885ec > > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java > bffdb0b > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java a82cf03 > > webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java > b1c8ce0 > > Diff: https://reviews.apache.org/r/42188/diff/ > > > Testing > ------- > > Added IT and did manual testing. > > > Thanks, > > Pallavi Rao > >
