> On Jan. 21, 2016, 12:04 p.m., pavan kumar kolamuri wrote:
> > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java,
> >  line 116
> > <https://reviews.apache.org/r/42459/diff/2/?file=1204356#file1204356line116>
> >
> >     Are you sure this change wont affect with derby ? If testcases run 
> > mostly it should be fine.

Yes. Testcases are passing.


- Deepak


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42459/#review115608
-----------------------------------------------------------


On Jan. 21, 2016, 11:56 a.m., Deepak Barr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42459/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2016, 11:56 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1664
>     https://issues.apache.org/jira/browse/FALCON-1664
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Added postgres support.
> 
> 
> Diffs
> -----
> 
>   common/src/main/resources/statestore.properties a67a871 
>   docs/src/site/twiki/FalconNativeScheduler.twiki 6f0679e 
>   pom.xml 39ee9ac 
>   scheduler/pom.xml 6392e98 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 
> 5ed3ccd 
>   scheduler/src/main/java/org/apache/falcon/tools/FalconStateStoreDBCLI.java 
> 7f22b0e 
>   scheduler/src/main/resources/META-INF/persistence.xml 99e116c 
>   src/conf/statestore.properties 0c912ad 
> 
> Diff: https://reviews.apache.org/r/42459/diff/
> 
> 
> Testing
> -------
> 
> Yes. Tested with PostgreSQL 9.5. 
> Ran the following command and got no errors -
> mvn clean install -Ptest-patch,hadoop-2
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

Reply via email to