> On Jan. 22, 2016, 5:54 a.m., Praveen Adlakha wrote: > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java, > > line 160 > > <https://reviews.apache.org/r/42455/diff/1/?file=1200183#file1200183line160> > > > > We should use either LOG.info or LOG.error in this case. > > LOG.info if we intend to do nothing because debug mode will not be > > enabled every time.
It is getting logged currently and Pragya says it is noise. Hence was planning to move it to debug. But, honestly, I don't myself like the idea of hiding exception indiscriminately. Let me upload a new patch - Pallavi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42455/#review115790 ----------------------------------------------------------- On Jan. 18, 2016, 12:21 p.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42455/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 12:21 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1754 > https://issues.apache.org/jira/browse/FALCON-1754 > > > Repository: falcon-git > > > Description > ------- > > The Service should continue to notify other handlers on exception > > > Diffs > ----- > > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java > 4278d3f > > Diff: https://reviews.apache.org/r/42455/diff/ > > > Testing > ------- > > > Thanks, > > Pallavi Rao > >
