[
https://issues.apache.org/jira/browse/FALCON-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134076#comment-15134076
]
Pragya Mittal commented on FALCON-1819:
---------------------------------------
I see that you have put in the patch. Looks good to me.
Adding one more point to the discussion :-
There are test cases where names are explicitly defined by user and there
deletion has to be consciously handled. We need to handle such scenarios also
which does not follow the form like:
- <prefix> [entity name itself] - Where prefix is either test class name or
- <'A'>+test class name hash code (depending on is_deprecate property from
Merlin.properties)
[~pisaychuk] Thoughts please.
> Improve test class entity cleanup logic
> ---------------------------------------
>
> Key: FALCON-1819
> URL: https://issues.apache.org/jira/browse/FALCON-1819
> Project: Falcon
> Issue Type: Bug
> Components: merlin
> Affects Versions: 0.7
> Reporter: Paul Isaychuk
> Assignee: Paul Isaychuk
> Fix For: trunk
>
>
> From discussion with Pragya Mittal:
> To got cleaned up, entity should have a name of form like: <prefix> \[entity
> name itself\]. Where prefix is either test class name or <'A'>+test class
> name hash code (depending on is_deprecate property from Merlin.properties).
> If entity name is something else, it wouldn't be removed.
> But seems that in case of
> FeedSubmitAndScheduleTest#snsDiffFeedDiffUserSameCluster feed is not getting
> deleted not bacause of that.
> As another user (root) is involved in test case (by submitting feed that
> belongs to this another user), we don't see that feed in listing feeds as
> test user (which is used by default to list and remove entities). Makes sense?
> So we need to improve clean up logic to handle entities belonging to
> different users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
