-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64208/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-2314
https://issues.apache.org/jira/browse/FALCON-2314
Repository: falcon-git
Description
-------
In our environment we needed to get rid of LGPL BeanShell TestNG dependency. In
this case
EvictedInstanceSerDeTest.testDeserializeEvictedInstancePathsForNoEviction is
failing. The reason of the fail is the newer TestNG runs the two Serialize
method first, then runs the two Deserialize next. This means
testDeserializeEvictedInstancePathsForNoEviction which tests for empty files
found a file with unexpected content and fails.
I suggest splitting the two files into different ones as first attached patch
shows.
Diffs
-----
common/src/test/java/org/apache/falcon/retention/EvictedInstanceSerDeTest.java
0f2ee7b8ea74a868900803b2a873db95d82a7a4b
pom.xml 8e836da98a7f21148c72d92311c6aff63fe7ca36
Diff: https://reviews.apache.org/r/64208/diff/1/
Testing
-------
I ran mvn test locally and got 100% result with this modification.
Thanks,
Denes Bodo
