[ 
https://issues.apache.org/jira/browse/FALCON-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274323#comment-16274323
 ] 

ASF GitHub Bot commented on FALCON-2314:
----------------------------------------

GitHub user dionusos opened a pull request:

    https://github.com/apache/falcon/pull/390

    FALCON-2314 Bump TestNG version to 6.13.1 to avoid BeanShell dependency

    Build and tests are good locally.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dionusos/falcon FALCON-2314

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/falcon/pull/390.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #390
    
----
commit 5b57fa74e6942092a6471a3b189a8f49b5f21c41
Author: Denes Bodo <[email protected]>
Date:   2017-11-30T10:22:43Z

    FALCON-2314 Bump TestNG version to 6.13.1 to avoid BeanShell dependency
    
    Change-Id: If872873a96a08f72b13447eb35531064d97a7e29

----


> Bump TestNG version to 6.13.1 to avoid BeanShell dependency
> -----------------------------------------------------------
>
>                 Key: FALCON-2314
>                 URL: https://issues.apache.org/jira/browse/FALCON-2314
>             Project: Falcon
>          Issue Type: Bug
>          Components: client, tests
>    Affects Versions: 0.10
>            Reporter: Denes Bodo
>            Assignee: Denes Bodo
>         Attachments: FALCON-2314_001.patch
>
>
> In our environment we needed to get rid of LGPL BeanShell TestNG dependency. 
> In this case 
> EvictedInstanceSerDeTest.testDeserializeEvictedInstancePathsForNoEviction is 
> failing. The reason of the fail is the newer TestNG runs the two Serialize 
> method first, then runs the two Deserialize next. This means 
> testDeserializeEvictedInstancePathsForNoEviction which tests for empty files 
> found a file with unexpected content and fails.
> I suggest splitting the two files into different ones as first attached patch 
> shows.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to