[
https://issues.apache.org/jira/browse/FALCON-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13736904#comment-13736904
]
Srikanth Sundarrajan edited comment on FALCON-72 at 8/12/13 2:33 PM:
---------------------------------------------------------------------
Looks good. Couple of minor observations:
1. When the storage url is validated, the exception says "Invalid HDFS ...". It
might be better to avoid assuming that the storage url is actually hdfs. It
could be s3:// for instance
2. Can we add a method to AbstractWorkflowEngine to validate the Workflow URL
validity and not have to implement any specific validation here. If we apply
security patch and the version api, is rejected due to missing ticket, this
might break.
was (Author: sriksun):
Looks good. Couple of minor observations:
1. When the storage url is validated, the exception says "Invalid HDFS ...". It
might be better to avoid assuming that the storage url is actually hdfs. It
could be s3:// for instance
2. Can we add a method to AbstractWorkflowEngine to validate the Workflow URL
validity and not have to do what is being done there. If we apply security
patch and the version api, is rejected due to missing ticket, this might break.
> Feeds with invalid oozie URI in cluster cannot be deleted
> ---------------------------------------------------------
>
> Key: FALCON-72
> URL: https://issues.apache.org/jira/browse/FALCON-72
> Project: Falcon
> Issue Type: Bug
> Components: general
> Affects Versions: 0.3
> Reporter: Venkatesh Seetharam
> Assignee: Venkatesh Seetharam
> Attachments: FALCON-72.patch, FALCON-72.r1.patch
>
>
> User submits a cluster dsl with a bad oozie uri. He then submits a feed with
> this cluster. User will never be able to remove the feed from Falcon.
> I'd suggest we add validations for all the interfaces:
> * Execute - create a JobClient object
> * Workflow - This is initialized quite late
> * Messaging - not sure if we need to validate this? Will Falcon work without
> this?
> * Read - Why not validate this as well?
> Thanks Grant Liu for bringing this to my attention.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
