[
https://issues.apache.org/jira/browse/FALCON-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817726#comment-13817726
]
Venkatesh Seetharam commented on FALCON-177:
--------------------------------------------
After looking into the code, I think this might have been taken care of. Lets
look at the details and see if your concerns are addressed.
bq. For HCat feeds, partitions can't be specified at feed level.
Yes. The code below takes care of it.
{code}
private void validatePartitions(Feed feed, Storage.TYPE storageType) throws
FalconException {
if (storageType == Storage.TYPE.TABLE && feed.getPartitions() != null) {
throw new ValidationException("Partitions are not supported for
feeds with table storage. "
+ "It should be defined as part of the table URI. "
+ feed.getName());
}
}
{code}
bq. FeedEntityParser.validateFeedPartitionExpression() validates that number of
partitions in partition expression <= number of partitions specified globally
in feed.
The above code validates before
org.apache.falcon.entity.parser.FeedEntityParser#validateFeedPartitionExpression
is invoked.
I do not want to completely disable this since there are other validations
apart from this being performed which is useful, like cluster defined more than
once, etc.
Also I think this won't apply after FALCON-180.
bq. Even CrossEntityValidations.validateInputPartition() can't be done for hcat
feeds
This will be addressed in FALCON-182.
Makes sense? LMK if this covers all grounds. Thanks, your comments are quite
useful.
> validate partition expression should not be done for hcat feeds
> ---------------------------------------------------------------
>
> Key: FALCON-177
> URL: https://issues.apache.org/jira/browse/FALCON-177
> Project: Falcon
> Issue Type: Bug
> Reporter: Shwetha G S
>
> For HCat feeds, partitions can't be specified at feed level. But feed xml can
> contain partition expression at feed's cluster which is used for replication.
> FeedEntityParser.validateFeedPartitionExpression() validates that number of
> partitions in partition expression <= number of partitions specified globally
> in feed. For hcat based feed, this validation shouldn't be done
--
This message was sent by Atlassian JIRA
(v6.1#6144)
