[ 
https://issues.apache.org/jira/browse/FALCON-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13874518#comment-13874518
 ] 

Jean-Baptiste Onofré commented on FALCON-268:
---------------------------------------------

Yes, but current falcon admin -status returns the error code. The problem is 
not in the script, it's in the CLI.

status exit with the client response (200 if OK, something different from 200 
if not OK), and the script uses it to determine if falcon is operating 
correctly or not.

If we remove System.exit() from CLI status, the script can't check the return 
code so it will return 0 (success) even if it's not really a success.

Of course, we can just display a message in CLI status, but it means that it's 
not very useful for scripting.

I propose:
1/ to remove the System.exit() in CLI status
2/ just display a message in status
3/ don't actually check the CLI status in status-service

WDYT ?

> Checkstyle/Findbugs issues on FalconCLI
> ---------------------------------------
>
>                 Key: FALCON-268
>                 URL: https://issues.apache.org/jira/browse/FALCON-268
>             Project: Falcon
>          Issue Type: Bug
>          Components: client
>            Reporter: Jean-Baptiste Onofré
>            Assignee: Jean-Baptiste Onofré
>         Attachments: FALCON-268.patch
>
>
> Falcon doesn't build due to a checkstyle issue on FalconCLI.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to