[ 
https://issues.apache.org/jira/browse/FALCON-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920712#comment-13920712
 ] 

Shaik Idris Ali commented on FALCON-286:
----------------------------------------

This JIRA seems to be more of cleanup/fixes:

1. In OozieFeedMapper:
{code}
-            props.put(ARG.feedInstancePaths.getPropName(), instancePaths);
+            props.put(ARG.feedInstancePaths.getPropName(), 
"${coord:dataOut('output')}");
{code}, 
initially replication was designed for same input/output path, but now make 
sense to have output event

2. {code}
        props.put("userWorkflowEngine", "falcon");
    {code} In process mapper, value is coming from XSD, but for feed it is 
hardcoded here, should we follow the same convention and add falcon as another 
engineType, I am yet to review other patch, so still not sure about the intent 
of having this here. 

2. In OozieProcessMapper:
{code}
        if (process.getInputs() == null) {
            return;
        }
{code}
Nice, this seems to be bug fix after making this as optional.

3. In OozieProcessMapper
{code}
 inputFeeds.add(feed.getName());
&
outputFeeds.add(feed.getName());
{code}
This will create a problem, basically user can define in a process, for a same 
feed multiple inputEvents/outputEvents
with different ranges.





> Capture information in process entity about the user workflow
> -------------------------------------------------------------
>
>                 Key: FALCON-286
>                 URL: https://issues.apache.org/jira/browse/FALCON-286
>             Project: Falcon
>          Issue Type: Sub-task
>    Affects Versions: 0.5
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>              Labels: lineage
>         Attachments: FALCON-286-v1.patch, FALCON-286-v2.patch, 
> FALCON-286.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to