[ 
https://issues.apache.org/jira/browse/FALCON-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046401#comment-14046401
 ] 

Shaik Idris Ali commented on FALCON-484:
----------------------------------------

** Is the Instrumentation being taken care? the aspect plugin requires some 
refactoring.
GenericAlert.instrumentFailedInstance
I was not able to verify with UTs.

* Can WorkflowExecutionContext.serialize() catch IOexception and simply wrap 
FalconException ?

* If all WorkflowExecutionContext args used for generating Options, then its 
better to simply iterate over args in WorkflowExecutionContext.getCommand() 
method by adding the isRequired option to WorkflowExecutionContext enums.
NOMINAL_TIME("nominalTime", "instance time", true)

> Refactor workflow related code into context, listener and Notification
> ----------------------------------------------------------------------
>
>                 Key: FALCON-484
>                 URL: https://issues.apache.org/jira/browse/FALCON-484
>             Project: Falcon
>          Issue Type: Sub-task
>          Components: messaging
>    Affects Versions: 0.6
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>              Labels: refactoring
>             Fix For: 0.6
>
>         Attachments: FALCON-484.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to