[
https://issues.apache.org/jira/browse/FALCON-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046437#comment-14046437
]
Shaik Idris Ali edited comment on FALCON-485 at 6/27/14 11:48 PM:
------------------------------------------------------------------
[~svenkat] I was busy this Thursday
* Is this change backward compatible, with just Falcon Server upgrade, how does
message flow happens to/from the scheduled "post-processing" actions from/to
Falcon as the context file will be missing?
* Looks like a bug. For now I have proceeded the review/testing by changing the
code.
Got to know by seeing exceptions in JMSMessageConsumerTest
{quote}<MAY be testcase is passing wrong arguments and just ignoring
exceptions.>{quote}
{code}
public String getValue(WorkflowExecutionArgs arg) {
return context.get(arg.getName()); Instead of context.get(arg), which
actually returns Enum's name which is capital.
}
{code}
* Actually enum already has a method name() and getName() is adding more
confusion to it. Just realised the other ProcessProducerTest is failing now.
Can you please look at WorkflowExecutionContext.create() and its behaviour with
all Messaging testcases.
{quote}
Looks like JSON serializer/deserilizer is treating the ENUM has
Map<String,String> instead of Map<WorkflowArg,String>
{quote}
was (Author: shaik.idris):
[~svenkat] I was busy this Thursday
* Is this change backward compatible, with just Falcon Server upgrade, how does
message flow happens to/from the scheduled "post-processing" actions from/to
Falcon as the context file will be missing?
* Looks like a bug. For now I have proceeded the review/testing by changing the
code.
Got to know by seeing exceptions in JMSMessageConsumerTest
{quote}<MAY be testcase is passing wrong arguments and just ignoring
exceptions.>{quote}
{code}
public String getValue(WorkflowExecutionArgs arg) {
return context.get(arg.getName()); Instead of context.get(arg), which
actually returns Enum's name which is capital.
}
{code}
* Actually enum already has a method name() and getName() is adding more
confusion to it. Just realised the other ProcessProducerTest is failing now.
Can you please look at WorkflowExecutionContext.create() and its behaviour with
all Messaging testcases.
> Simplify JMS Message Sender/Consumer and use Workflow Context
> -------------------------------------------------------------
>
> Key: FALCON-485
> URL: https://issues.apache.org/jira/browse/FALCON-485
> Project: Falcon
> Issue Type: Sub-task
> Components: messaging
> Affects Versions: 0.6
> Reporter: Venkatesh Seetharam
> Assignee: Venkatesh Seetharam
> Labels: refactoring
> Fix For: 0.6
>
> Attachments: FALCON-485.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
