----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23483/ -----------------------------------------------------------
Review request for Falcon. Bugs: FALCON-353 https://issues.apache.org/jira/browse/FALCON-353 Repository: falcon-git Description ------- Entity schedule creates a bundle in oozie. But bundle submit is asynchronous and coord create can fail and creates bad user experience. So, this patch uses dryRun feature of oozie to validate the entity before scheduling in oozie. DryRun is used in validate(), schedule() and update() Diffs ----- common/src/main/java/org/apache/falcon/entity/EntityUtil.java a38e553 common/src/main/java/org/apache/falcon/update/UpdateHelper.java 7af77d0 common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java eedd81f common/src/test/java/org/apache/falcon/update/UpdateHelperTest.java e532b24 oozie/src/main/java/org/apache/falcon/oozie/OozieBundleBuilder.java 2018db2 oozie/src/main/java/org/apache/falcon/oozie/OozieCoordinatorBuilder.java 5a29683 oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java bb8dfcc oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java ac78297 oozie/src/main/java/org/apache/falcon/oozie/feed/FeedBundleBuilder.java 6917f4e oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationCoordinatorBuilder.java 3226cf2 oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationWorkflowBuilder.java 00fab99 oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionCoordinatorBuilder.java 4393c94 oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionWorkflowBuilder.java 4a7f96b oozie/src/main/java/org/apache/falcon/oozie/process/ProcessBundleBuilder.java 86cea93 oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionCoordinatorBuilder.java c87bc86 oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionWorkflowBuilder.java 0d9abdb oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 38be792 oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 542634d oozie/src/test/java/org/apache/falcon/oozie/process/AbstractTestBase.java 54a2ea7 oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java 5ceea75 prism/src/main/java/org/apache/falcon/FalconWebException.java d552c07 prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java c135470 webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java e214392 webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java dceb2f2 webapp/src/test/java/org/apache/falcon/resource/TestContext.java bc79609 Diff: https://reviews.apache.org/r/23483/diff/ Testing ------- UTs + manual end to end test of feed retention and process schedule and update Thanks, shwethags