----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24311/#review49717 -----------------------------------------------------------
addons/designer/actions/src/main/java/org/apache/falcon/designer/action/configuration/EmailActionConfiguration.java <https://reviews.apache.org/r/24311/#comment87029> rename to to, cc and subject? addons/designer/core/pom.xml <https://reviews.apache.org/r/24311/#comment87030> format addons/designer/core/src/main/java/org/apache/falcon/designer/action/serde/PrimitiveSerDe.java <https://reviews.apache.org/r/24311/#comment87031> shouldn't the serde methods go to configuration? addons/designer/core/src/main/java/org/apache/falcon/designer/primitive/Primitive.java <https://reviews.apache.org/r/24311/#comment87032> serde methods should be configuration so this will look like conf.serialise() addons/designer/pom.xml <https://reviews.apache.org/r/24311/#comment87028> this should be project.version. Why define another variable designer.version? - shwethags On Aug. 5, 2014, 12:20 p.m., samar kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24311/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 12:20 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-553 > https://issues.apache.org/jira/browse/FALCON-553 > > > Repository: falcon-git > > > Description > ------- > > Base line the code and https://issues.apache.org/jira/browse/FALCON-553 in > progress > > > Diffs > ----- > > addons/designer/actions/pom.xml 7d5afbb > > addons/designer/actions/src/main/java/org/apache/falcon/designer/action/configuration/EmailActionConfiguration.java > PRE-CREATION > > addons/designer/actions/src/main/java/org/apache/falcon/designer/action/serde/ActionSerDe.java > PRE-CREATION > > addons/designer/actions/src/main/java/org/apache/falcon/designer/action/serde/impl/EmailActionSerde.java > PRE-CREATION > > addons/designer/actions/src/main/java/org/apache/falcon/designer/primitive/action/EmailAction.java > PRE-CREATION > addons/designer/core/pom.xml ddd8814 > > addons/designer/core/src/main/java/org/apache/falcon/designer/action/serde/PrimitiveSerDe.java > PRE-CREATION > > addons/designer/core/src/main/java/org/apache/falcon/designer/configuration/ActionConfiguration.java > PRE-CREATION > > addons/designer/core/src/main/java/org/apache/falcon/designer/configuration/Configuration.java > dba908a > > addons/designer/core/src/main/java/org/apache/falcon/designer/configuration/FlowConfig.java > PRE-CREATION > > addons/designer/core/src/main/java/org/apache/falcon/designer/configuration/TransformConfiguration.java > PRE-CREATION > > addons/designer/core/src/main/java/org/apache/falcon/designer/primitive/Action.java > c40e462 > > addons/designer/core/src/main/java/org/apache/falcon/designer/primitive/Primitive.java > aa2b988 > > addons/designer/core/src/main/java/org/apache/falcon/designer/primitive/Transform.java > 72cf988 > > addons/designer/core/src/main/java/org/apache/falcon/designer/storage/impl/HDFSStorage.java > PRE-CREATION > > addons/designer/core/src/test/java/org/apache/falcon/designer/storage/impl/HDFSStorageTest.java > PRE-CREATION > addons/designer/flows/pom.xml ce706a3 > > addons/designer/flows/src/main/java/org/apache/falcon/designer/flow/serde/FlowSerde.java > PRE-CREATION > > addons/designer/flows/src/main/java/org/apache/falcon/designer/primitive/Flow.java > PRE-CREATION > addons/designer/pom.xml 3e1a98a > > Diff: https://reviews.apache.org/r/24311/diff/ > > > Testing > ------- > > > Thanks, > > samar kumar > >
