[
https://issues.apache.org/jira/browse/FALCON-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101201#comment-14101201
]
Venkatesh Seetharam commented on FALCON-470:
--------------------------------------------
[~bvellanki], few minor nits:
* FalconCLI
Why is this necessary. Pls pass null.
{code}
if (orderBy == null) {
orderBy = "";
}
if (filterBy == null) {
filterBy = "";
}
if (instanceOrderBy == null) {
instanceOrderBy = "";
}
if (instanceFilter == null) {
instanceFilter = "";
}
if (fields == null) {
fields = "";
}
{code}
* FalconClient
{code}if (filterBy != null && !filterBy.equals("")) {{code}
Use StringUtils.isEmpty instead
* I do not see unit tests for pipelines. BTW, I thought you'd have a separate
patch for pipeline element for process.
> Add support for pagination to list API
> --------------------------------------
>
> Key: FALCON-470
> URL: https://issues.apache.org/jira/browse/FALCON-470
> Project: Falcon
> Issue Type: Sub-task
> Components: webapp
> Affects Versions: 0.6
> Reporter: Venkatesh Seetharam
> Assignee: Balu Vellanki
> Labels: rest_api
> Fix For: 0.6
>
> Attachments: Falcon-Jira-470-471-472-473-v1.patch,
> Falcon-Jira-470-471-472-473-v3.patch, Falcon-Jira-470-471-472-473-v4.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
