> On Aug. 14, 2014, 2:38 p.m., Arpit Gupta wrote:
> > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java,
> > line 417
> > <https://reviews.apache.org/r/24717/diff/1/?file=660858#file660858line417>
> >
> > I am assuming that is a path only on hdfs hence we dont need it to be
> > os specific. If that is the case plase add a comment. Better yet change the
> > name to imply that you are only swithing hdfs paths.
I am stiching(no switching) paths - the goal is handle starting and trailing /
nicely. For eg:
stitchPath("/tmp/", "/test") = "/tmp/test"
stitchPath("/tmp/", "test") = "/tmp/test"
stitchPath("/tmp", "test") = "/tmp/test"
- Raghav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24717/#review50644
-----------------------------------------------------------
On Aug. 14, 2014, 2:21 p.m., Raghav Gautam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24717/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2014, 2:21 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: falcon-606
> https://issues.apache.org/jira/browse/falcon-606
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> This patch attempts to remove requirement of 777 access to / for hcat tests.
>
>
> Diffs
> -----
>
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java
> 57c7292
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java
> 1f73523
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java
> c33700c
>
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java
> c64ddad
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatProcessTest.java
> 32062ba
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatReplicationTest.java
> 860e680
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatRetentionTest.java
> cce2860
> falcon-regression/merlin/src/test/resources/hcat/cluster-0.1.xml 5396835
> falcon-regression/merlin/src/test/resources/hcat/data/_SUCCESS 004c62e
> falcon-regression/merlin/src/test/resources/hcat_2/cluster-0.1.xml 9be1b2c
>
> Diff: https://reviews.apache.org/r/24717/diff/
>
>
> Testing
> -------
>
> HCatProcessTest, HCatRetention, HCatReplicationTest
>
>
> Thanks,
>
> Raghav Gautam
>
>
