> On Sept. 3, 2014, 10:10 a.m., samarth gupta wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java, > > line 166 > > <https://reviews.apache.org/r/25294/diff/1/?file=675065#file675065line166> > > > > it this check really needed ... i think checking the run ID should be > > good enough
This is just an extra check, to ensure that process actually succeeded with no failures. Although testing for run Id will suffice. Will remove it as i see it is not required. - PRAGYA ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25294/#review52153 ----------------------------------------------------------- On Sept. 3, 2014, 9:56 a.m., PRAGYA MITTAL wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25294/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2014, 9:56 a.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > Late data regression test for feed and process > > > Diffs > ----- > > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java > PRE-CREATION > > falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/process-agg.xml > 09e8a09 > > Diff: https://reviews.apache.org/r/25294/diff/ > > > Testing > ------- > > > Thanks, > > PRAGYA MITTAL > >
