----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25425/#review52583 -----------------------------------------------------------
common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java <https://reviews.apache.org/r/25425/#comment91438> Use StringUtils.equals which handles null common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java <https://reviews.apache.org/r/25425/#comment91437> return null for location - shwethags On Sept. 8, 2014, 7:02 a.m., Suhas Vasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25425/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2014, 7:02 a.m.) > > > Review request for Falcon and shwethags. > > > Repository: falcon-git > > > Description > ------- > > If a feed does not have stats path specified, it assumes it as /tmp/ on the > hdfs. Ideally we should be throwing an error that the specified feed does not > have a stats path. > > Users may have specified to delete the stats path if it exists, in the > prepare tag in workflow. In such a scenario the whole of /tmp/ is cleared, > which is totally undesirable. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java > 4eb3d60 > common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java > a78c678 > > oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionCoordinatorBuilder.java > 1fa6758 > > oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java > 23c01a9 > > Diff: https://reviews.apache.org/r/25425/diff/ > > > Testing > ------- > > > Thanks, > > Suhas Vasu > >
