----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25211/#review53155 -----------------------------------------------------------
common/src/main/java/org/apache/falcon/entity/CatalogStorage.java <https://reviews.apache.org/r/25211/#comment92614> Please enumerate the imports common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java <https://reviews.apache.org/r/25211/#comment92615> Are you better off using StringBuilder? Haven't checked the actual evict logic. Can you confirm if it is merely moved from FeedEvictor into respective Storage classes or have they been modified as well ? - Srikanth Sundarrajan On Sept. 6, 2014, 8:41 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25211/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2014, 8:41 p.m.) > > > Review request for Falcon and shwethags. > > > Repository: falcon-git > > > Description > ------- > > Earlier FeedEviction class contained logic for both FileSystemStorage and > TableStorage. Corresponding code was being called using an if else. To make > the code cleaner and more manageable I moved the code to the appropriate > storage class and delegated feed eviction to the appropriate Storage > implementation. Needed to add evict method to Storage Interface and make some > minor changes here and there. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 7ad0716 > common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java > 4eb3d60 > common/src/main/java/org/apache/falcon/entity/Storage.java f88e139 > common/src/main/java/org/apache/falcon/retention/EvictionHelper.java > 5d6481c > retention/src/main/java/org/apache/falcon/retention/FeedEvictor.java > 114071f > > Diff: https://reviews.apache.org/r/25211/diff/ > > > Testing > ------- > > All FeedEvictor tests passed. > > > Thanks, > > Ajay Yadava > >
