[ 
https://issues.apache.org/jira/browse/FALCON-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14139296#comment-14139296
 ] 

Venkatesh Seetharam commented on FALCON-740:
--------------------------------------------

[~shwethags], can you please elaborate on your comment
bq. Bundle end time can be changed, even though it may not be documented. To 
differentiate between manual kill and status change in oozie, we set end time. 
*But now, we check the staging path to find the bundles for a given entity.* 
So, we can remove set end time

> Entity kill job calls OozieClient.kill on bundle coord job ids before calling 
> kill on bundle job id
> ---------------------------------------------------------------------------------------------------
>
>                 Key: FALCON-740
>                 URL: https://issues.apache.org/jira/browse/FALCON-740
>             Project: Falcon
>          Issue Type: Bug
>          Components: webapp
>    Affects Versions: 0.6
>            Reporter: Balu Vellanki
>            Assignee: Balu Vellanki
>
> When Falcon user makes an entity kill API call, Falcon does the following in 
> org.apache.falcon.workflow.engine.OozieWorkflowEngine.killBundle(String 
> clusterName, BundleJob job)
> {code}
>  //kill all coords
>             for (CoordinatorJob coord : job.getCoordinators()) {
>                 client.kill(coord.getId());
>                 LOG.debug("Killed coord {} on cluster {}", coord.getId(), 
> clusterName);
>             }
>             //set end time of bundle
>             client.change(job.getId(), OozieClient.CHANGE_VALUE_ENDTIME + "=" 
> + SchemaHelper.formatDateUTC(new Date()));
>             LOG.debug("Changed end time of bundle {} on cluster {}", 
> job.getId(), clusterName);
>             //kill bundle
>             client.kill(job.getId());
>             LOG.debug("Killed bundle {} on cluster {}", job.getId(), 
> clusterName);
> {code}
> Two questions.
> 1. Why should we kill the coordinator jobs before killing the bundle job? 
> OozieClient.kill(bundle_job_id) should kill all the bundle's coord jobs.
> 2. Why is the endtime changed for  bundle job? 
> https://oozie.apache.org/docs/4.0.1/DG_CommandLineTool.html#Changing_pausetime_of_a_Bundle_Job
>  does not say that endtime can be changed for bundlejob. 
> I think this code should be updated, please comment if you think I made any 
> wrong assumptions.
> Thank you



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to