[
https://issues.apache.org/jira/browse/FALCON-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154376#comment-14154376
]
Ajay Yadav commented on FALCON-145:
-----------------------------------
v2 was the patch that you reviewed.
By the time the review got over, there were several changes in the trunk and
had to rebase it. So I generated v3.
While generating v3 I gave wrong command and one new file which was added got
missed. So generated v4. v4 is the correct rebased patch.
There is no change in any logic or code from what you reviewed.
> Feed eviction be implemented in appropriate Storage implementation
> ------------------------------------------------------------------
>
> Key: FALCON-145
> URL: https://issues.apache.org/jira/browse/FALCON-145
> Project: Falcon
> Issue Type: Improvement
> Reporter: Venkatesh Seetharam
> Assignee: Ajay Yadav
> Attachments: FALCON-145-v2.patch, FALCON-145-v3.patch,
> FALCON-145-v4.patch, falcon-145.patch
>
>
> Since the feed storage is abstracted in Storage class either as
> FileSystemStorage or CatalogStorage, moreover, behaviors for listing
> partitions and drop partitions are listed there, why do we need to hardcode
> the eviction behavior and instance deletion discovery for filesystem need to
> happen in FeedEvictor ? Why can't be implemented in appropriate Storage
> implementation. That way FeedEvictor would simpler and lot cleaner.
> This can apply to table replication as well for import and export of
> partitions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
