[
https://issues.apache.org/jira/browse/FALCON-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162954#comment-14162954
]
Venkatesh Seetharam commented on FALCON-788:
--------------------------------------------
patch looks good but one minor nit;
- throw new
WebApplicationException(Response.status(Response.Status.INTERNAL_SERVER_ERROR)
- .entity(JSONObject.quote("An error occurred: " +
e.getMessage())).build());
+ throw FalconWebException.newException(e,
Response.Status.INTERNAL_SERVER_ERROR);
Pls log exceptions before rethrowing 'em
> Lineage: Minor bug fixes
> ------------------------
>
> Key: FALCON-788
> URL: https://issues.apache.org/jira/browse/FALCON-788
> Project: Falcon
> Issue Type: Bug
> Affects Versions: 0.6
> Reporter: Sowmya Ramesh
> Assignee: Sowmya Ramesh
> Labels: lineage
> Fix For: 0.6
>
> Attachments: FALCON-788.patch
>
>
> Couple of issues
> 1> Currently in LineageMetadataResource if there is a JSONException then
> WebApplicationException is thrown. Client receives INTERNAL_SERVER_ERROR with
> no message. Also Falcon applicaiton logs doesn't have stack trace. Throw
> FalconWebException which would log exception message and throw it for
> debugging purposes
> 2> Fixed couple of minor bugs if MetadataMappingService is not enabled
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
