----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26544/#review56112 -----------------------------------------------------------
client/src/main/java/org/apache/falcon/client/FalconClient.java <https://reviews.apache.org/r/26544/#comment96448> Should it be a \n instead of \t? common/src/main/java/org/apache/falcon/entity/FeedHelper.java <https://reviews.apache.org/r/26544/#comment96449> Even though it's private, it will be very helpful to document with an example input and output. common/src/main/java/org/apache/falcon/entity/FeedInstanceStatus.java <https://reviews.apache.org/r/26544/#comment96450> Did you mean? Partial if partition is setup, but availability flag is missing. common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java <https://reviews.apache.org/r/26544/#comment96451> Pagination will be helpful IMHO, though it shouldn't be a blocker for this feature. common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java <https://reviews.apache.org/r/26544/#comment96452> How about making start and end optional? In that case we can return latest 10 results. common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java <https://reviews.apache.org/r/26544/#comment96453> How about storing feed availability and feed path in Graph DB? That way it will be very easy for others to query last 10 instances etc. Won't it? Can we add documentation for the Client and the REST API? On a slightly side note: we currently don't document error responses in REST API, it will be very helpful if we do that. - Ajay Yadava On Oct. 10, 2014, 9:19 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26544/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2014, 9:19 a.m.) > > > Review request for Falcon and Ajay Yadava. > > > Repository: falcon-git > > > Description > ------- > > Support for listing feed instances for FileSystemStorage > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java f7229ec > client/src/main/java/org/apache/falcon/client/FalconClient.java d73560d > client/src/main/java/org/apache/falcon/resource/APIResult.java 79b8a1d > client/src/main/java/org/apache/falcon/resource/FeedInstanceResult.java > PRE-CREATION > client/src/main/java/org/apache/falcon/resource/InstancesResult.java > 5754f97 > client/src/main/java/org/apache/falcon/resource/InstancesSummaryResult.java > 0758c8b > common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 7ad0716 > common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 2689cb7 > common/src/main/java/org/apache/falcon/entity/FeedHelper.java 4174135 > common/src/main/java/org/apache/falcon/entity/FeedInstanceStatus.java > PRE-CREATION > common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java > 58506ad > common/src/main/java/org/apache/falcon/entity/Storage.java f88e139 > common/src/main/java/org/apache/falcon/expression/ExpressionHelper.java > 79d6e2d > common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java > 4bb7772 > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > fd8c63f > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java > fcd7b29 > prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java > 5e351f6 > > prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java > d172c3e > > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java > fbccd6b > > Diff: https://reviews.apache.org/r/26544/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
