> On Nov. 4, 2014, 7:02 a.m., Ruslan Ostafiychuk wrote: > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/FileUtil.java, > > line 44 > > <https://reviews.apache.org/r/27553/diff/1/?file=747895#file747895line44> > > > > Can we use printPrettyXML here?
Pretty printing is done in clientSubmit() method in IEntityManager class. The reason for this is that in FileUtil.writeEntityToFile() the purpose of writing xml is not known. Typically when we pretty print xml we also say if that entity is being scheduled/modified etc. And we want to follow that convention. - Raghav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27553/#review59767 ----------------------------------------------------------- On Nov. 3, 2014, 4:31 p.m., Raghav Gautam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27553/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2014, 4:31 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-861 > https://issues.apache.org/jira/browse/FALCON-861 > > > Repository: falcon-git > > > Description > ------- > > Add ACL tests for falcon client and ACL update > > > Diffs > ----- > > falcon-regression/merlin-core/pom.xml 21641a3 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java > dab5d2c > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/FalconClientBuilder.java > PRE-CREATION > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java > 7264142 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/ExecResult.java > f878aa8 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java > 569d1f3 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/ExecUtil.java > d240e76 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/FileUtil.java > PRE-CREATION > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java > 86d4d47 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/AclValidationTest.java > d7f21b7 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ClusterAclTest.java > affff56 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FeedAclTest.java > 79e5db6 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ProcessAclTest.java > f0775e7 > falcon-regression/pom.xml 0424cb8 > > Diff: https://reviews.apache.org/r/27553/diff/ > > > Testing > ------- > > Ran locally - the tests are not passing because of existing ACL issues. > > > Thanks, > > Raghav Gautam > >
