----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26912/#review60532 -----------------------------------------------------------
common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java <https://reviews.apache.org/r/26912/#comment101907> This is nested inside shouldStartExpression != null. So does that mean shouldEnd have relevance unless shouldStart is filled in ? Shouldn't this condition (shouldEnd != null) and associated checks be only based on the condition that sla is configured. - Srikanth Sundarrajan On Nov. 9, 2014, 6:36 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26912/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2014, 6:36 p.m.) > > > Review request for Falcon and Srikanth Sundarrajan. > > > Bugs: https://issues.apache.org/jira/browse/FALCON-722 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FALCON-722 > > > Repository: falcon-git > > > Description > ------- > > Add SLA for process. > > > Diffs > ----- > > client/src/main/resources/process-0.1.xsd 06a2fe4 > > common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java > 55887ac > > common/src/test/java/org/apache/falcon/entity/parser/ProcessEntityParserTest.java > e3a2cd5 > common/src/test/resources/config/process/process-0.1.xml 99a0376 > docs/src/site/twiki/EntitySpecification.twiki a81a626 > > Diff: https://reviews.apache.org/r/26912/diff/ > > > Testing > ------- > > Yes. All tests pass. > > > Thanks, > > Ajay Yadava > >
