----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26908/#review60536 -----------------------------------------------------------
common/src/main/java/org/apache/falcon/entity/store/FeedPathStore.java <https://reviews.apache.org/r/26908/#comment101909> Please javax.annotation.Nonnull. common/src/test/java/org/apache/falcon/util/RadixTreeTest.java <https://reviews.apache.org/r/26908/#comment101910> Use Logger. It is hard to control the behavior of what gets printed if sout is used. - Srikanth Sundarrajan On Nov. 6, 2014, 8:11 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26908/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 8:11 p.m.) > > > Review request for Falcon and Srikanth Sundarrajan. > > > Repository: falcon-git > > > Description > ------- > > Store for feed path(key) and feed properties like feed name etc. as values > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/store/FeedLocationStore.java > PRE-CREATION > common/src/main/java/org/apache/falcon/entity/store/FeedPathStore.java > PRE-CREATION > common/src/main/java/org/apache/falcon/util/RadixNode.java PRE-CREATION > common/src/main/java/org/apache/falcon/util/RadixTree.java PRE-CREATION > > common/src/test/java/org/apache/falcon/entity/store/FeedLocationStoreTest.java > PRE-CREATION > common/src/test/java/org/apache/falcon/util/RadixNodeTest.java PRE-CREATION > common/src/test/java/org/apache/falcon/util/RadixTreeTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/26908/diff/ > > > Testing > ------- > > Thorough unit testing for the patch submitted. > > > Thanks, > > Ajay Yadava > >
