----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27029/#review60729 -----------------------------------------------------------
messaging/src/main/java/org/apache/falcon/messaging/UserJMSMessageProducer.java <https://reviews.apache.org/r/27029/#comment102121> Documenting an example of how a message for feed/process looks like will help readers to understand what's going on. messaging/src/main/java/org/apache/falcon/messaging/UserJMSMessageProducer.java <https://reviews.apache.org/r/27029/#comment102120> It is probably better for the function to return a map instead of receiving one and modifying it as it will reduce coupling between the two methods and improve testability. messaging/src/main/java/org/apache/falcon/messaging/UserJMSMessageProducer.java <https://reviews.apache.org/r/27029/#comment102117> I think these lines can be removed. messaging/src/test/java/org/apache/falcon/messaging/JMSMessageProducerTest.java <https://reviews.apache.org/r/27029/#comment102115> Use logger. messaging/src/test/java/org/apache/falcon/messaging/ProcessProducerTest.java <https://reviews.apache.org/r/27029/#comment102116> Use Logger please. - Ajay Yadava On Nov. 10, 2014, 2:54 p.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27029/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 2:54 p.m.) > > > Review request for Falcon, Ajay Yadava, shwethags, and Srikanth Sundarrajan. > > > Bugs: FALCON-697 > https://issues.apache.org/jira/browse/FALCON-697 > > > Repository: falcon-git > > > Description > ------- > > In case of EVICTION and REPLICATION, generating one message per feed to both > FALCON topic and user topic with all feed paths > > In case of GENERATE, in system topic(FALCON.ENITITY.TOPIC) generating one > message per process with all the feed paths. In User topic(FALCON > Feedname/process), generating one message per feed for feed name topics and > one message per process topic with all the feed paths > > > Diffs > ----- > > > messaging/src/main/java/org/apache/falcon/messaging/FalconJMSMessageProducer.java > PRE-CREATION > messaging/src/main/java/org/apache/falcon/messaging/JMSMessageProducer.java > 629e6a5 > > messaging/src/main/java/org/apache/falcon/messaging/UserJMSMessageProducer.java > PRE-CREATION > messaging/src/test/java/org/apache/falcon/messaging/FeedProducerTest.java > 2f5aa70 > > messaging/src/test/java/org/apache/falcon/messaging/JMSMessageProducerTest.java > d4373de > > messaging/src/test/java/org/apache/falcon/messaging/ProcessProducerTest.java > 1cd3310 > > Diff: https://reviews.apache.org/r/27029/diff/ > > > Testing > ------- > > Made UT changes to current tests > > > Thanks, > > Suma Shivaprasad > >
