[ 
https://issues.apache.org/jira/browse/FALCON-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205969#comment-14205969
 ] 

Shwetha G S commented on FALCON-869:
------------------------------------

+            instance.startTime = jobInfo.getStartTime();
+            instance.endTime = jobInfo.getEndTime();
+            instance.logFile = jobInfo.getConsoleUrl();
This should also go inside STATUS?

> Clean up required in the instance API calls.
> --------------------------------------------
>
>                 Key: FALCON-869
>                 URL: https://issues.apache.org/jira/browse/FALCON-869
>             Project: Falcon
>          Issue Type: Improvement
>            Reporter: Suhas Vasu
>            Assignee: Suhas Vasu
>            Priority: Minor
>         Attachments: FALCON-869.patch
>
>
> The instance API calls all go through the same function and only later do 
> specific stuff in the scheduler implementations. These specific stuff are too 
> cluttered and a bunch of the stuff are done irrespective of the API call.
> Ex: GetWorkFlowParams are called even for a {{-kill}} even though it is not 
> required. 
> It would be good if we clean this up. It will help in code maintainability



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to