[ 
https://issues.apache.org/jira/browse/FALCON-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217491#comment-14217491
 ] 

Ajay Yadav commented on FALCON-807:
-----------------------------------

This is not comprehensive. There are 1k+ violations across all modules and 
fixing all in one go will be very disruptive. It will conflict with most of the 
patches. I will update scope of this JIRA and make subtasks for various modules.

> Fix order of actual and expected expression in assert statements.
> -----------------------------------------------------------------
>
>                 Key: FALCON-807
>                 URL: https://issues.apache.org/jira/browse/FALCON-807
>             Project: Falcon
>          Issue Type: Improvement
>            Reporter: Ajay Yadav
>            Assignee: Ajay Yadav
>         Attachments: FALCON-807.patch
>
>
> In Assert statements like assertEquals, actual expression should be first and 
> expected expression should be second argument. In certain files e.g. 
> FalconCLIIT.java we have it other way round. 
> Impact of this is:
> When the test fails the error message will say something like:
> Expected -1 but was 0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to