[ 
https://issues.apache.org/jira/browse/FALCON-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224684#comment-14224684
 ] 

Ruslan Ostafiychuk commented on FALCON-900:
-------------------------------------------

[~raghavgautam]
Two files should be deleted.
There are still comments with "TODO" which can be replaced by new jiras if they 
should be done.
Also there are some classed without javadoc. It's present in patches in 
FALCON-684 and FALCON-698

> Release readiness for falcon-regression aka merlin
> --------------------------------------------------
>
>                 Key: FALCON-900
>                 URL: https://issues.apache.org/jira/browse/FALCON-900
>             Project: Falcon
>          Issue Type: Bug
>          Components: merlin
>    Affects Versions: 0.6
>            Reporter: Venkatesh Seetharam
>            Assignee: Raghav Kumar Gautam
>            Priority: Critical
>         Attachments: falcon-900-2.patch, falcon-900-3.patch, 
> falcon-900-4.patch, falcon-900.patch
>
>
> The following issues need to be addressed before merlin can be released along 
> with falcon.
> 1. Some files in the release fail rat check:
> {noformat}
>  !????? falcon-regression/merlin/src/test/resources/availabilityFlag.txt
>  !????? falcon-regression/merlin/src/test/resources/hcat/data/data.txt
>   A     falcon-regression/merlin/src/test/resources/ivory-oozie-lib-0.1.jar
>   A     falcon-regression/merlin/src/test/resources/IvoryClient/IvoryCLI.jar
>   A     
> falcon-regression/merlin/src/test/resources/oozie/lib/oozie-examples-3.1.5.jar
>   A     falcon-regression/merlin/src/test/resources/thriftRRMar0602.gz
>   A     
> falcon-regression/merlin/src/test/resources/workflows/aggregatorNoOutput/lib/oozie-examples-3.1.5.jar
> {noformat}
> --> No jar/archives to be included
> --> data.txt and availabilityFlag.txt doesn't have license headers and they 
> aren't  exempted with any additional LICENSE files/entries
> 1. Incorrect license header in 
> falcon-regression/merlin/src/test/resources/log_01.txt
> 1. There are references to "com.inmobi" in falcon-regression code
> 1. Falcon Regression - Build failure: Unable to build falcon-regression, 
> probably related to # above.
> 1. This is the first time falcon-regression is being released. We need to 
> verify this piece more thoroughly from license compliance perspective besides 
> ensuring that the build instructions are complete and self-sufficient. 
> Will probably need help from 
> @Samarth/@Arpit/@Raghav/@Ruslan/[~karishmag9]/[~pisaychuk] in verifying this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to